Fixed a few leaks in /PC/bdist_wininst/install.c#2142
Fixed a few leaks in /PC/bdist_wininst/install.c#2142tiagofilipesilva wants to merge 1 commit intopython:masterfrom tiagofilipesilva:master
Conversation
This commit fixes a few memory leaks in /PC/bdist_wininst/install.c
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
There are other leaks in this code.
| lines = (char **)realloc(lines, | ||
| sizeof(char *) * lines_buffer_size); | ||
| if (!lines) | ||
| if (!lines) { |
There was a problem hiding this comment.
The memory pointed by the old value of lines is leaked if realloc() returns NULL.
And seems lines is leaked in the code below.
serhiy-storchaka
changed the title
serhiy-storchaka
added
type-bug
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Please fix a leak in realloc().
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches |
|
@serhiy-storchaka, it appears that the original creator of this pull request has abandoned the issue. Since this concerns refleaks, should this PR be closed a new one opened to address the problems? Thanks. |
The author signed the CLA. You should try to find someone else to recreate this PR and fix the issue identified by @serhiy-storchaka. |
|
Created bpo-36901 for this pull request. |
7 participants
This trivial commit fixes a few memory leaks in /PC/bdist_wininst/install.c